tests/keyfile-utils: Drop tests covering preconditions

The spam in stderr was bothering me, and further at some eventual
point in the future we want to annotate the functions with
`__attribute__((nonnull))` which would then cause tests like these to
become undefined behavior.

The coverage of this isn't worth the log spam basically.

Closes: #611
Approved by: jlebon

diff --git a/tests/test-keyfile-utils.c b/tests/test-keyfile-utils.c
index 8fd59163a862882afec21541770bf2bc771a55b0..376b0e82e0cccedd3fff8434c8adb4c614a2feb1 100644 (file)
--- a/tests/test-keyfile-utils.c
+++ b/tests/test-keyfile-utils.c
@@ -34,37 +34,6 @@ test_get_boolean_with_default (void)
   g_autoptr(GError) error = NULL;
   gboolean out = FALSE;
 
-  GLogLevelFlags always_fatal_mask;
-
-  /* Avoid that g_return_val_if_fail causes the test to fail.  */
-  always_fatal_mask = g_log_set_always_fatal (0);
-
-
-  g_assert_false (ot_keyfile_get_boolean_with_default (NULL,
-                                                       "section",
-                                                       "a_boolean_true",
-                                                       FALSE,
-                                                       &out,
-                                                       &error));
-  g_clear_error (&error);
-  g_assert_false (ot_keyfile_get_boolean_with_default (g_keyfile,
-                                                       NULL,
-                                                       "a_boolean_true",
-                                                       FALSE,
-                                                       &out,
-                                                       &error));
-  g_clear_error (&error);
-  g_assert_false (ot_keyfile_get_boolean_with_default (g_keyfile,
-                                                       "section",
-                                                       NULL,
-                                                       FALSE,
-                                                       &out,
-                                                       &error));
-  g_clear_error (&error);
-
-  /* Restore the old mask.  */
-  g_log_set_always_fatal (always_fatal_mask);
-
   g_assert (ot_keyfile_get_boolean_with_default (g_keyfile,
                                                  "section",
                                                  "a_boolean_true",